Compat: fix float16(32)-renderable tests #4148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greggman
requested changes
Jan 15, 2025
There was a problem hiding this comment.
See comments.
I think the whole selectDeviceOrSkipTestCase system needs to be refactored.
Instead, off the top of my head,
- If no adapter has been requested then request one
- For each "selectXOrSkipTestCase" it should check the adapter, if no then skip, otherwise, add the requirements to some
deviceDescriptor - Only the end when the test actually starts (
GPUTestSubcaseBatchState.postInit?) should it actually make the device request.
As it is, only one feature can be selected.
I'm not sure that's the best design. Maybe you have other ideas. But, somehow the requirements need to be accumulated.
src/webgpu/api/operation/render_pipeline/pipeline_output_targets.spec.ts
Outdated
Show resolved
Hide resolved
shrekshao
force-pushed
the
float16-32-feature-fix
branch
from
6e707f8 to
c02fc90
Compare
|
Thanks for the refactor! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix by requesting
float16-renderableandfloat32-renderablefor related tests in compat mode.This CL only fixes a subset of the related test (operations)